search

ember-learn / deprecation-app

Deprecation guides for ember.js, ember-data, and ember-cli
https://deprecations.emberjs.com/
22 stars 69 forks source link

Add deprecations from Ember Data 5.x so far #1339

Closed Baltazore closed 10 months ago

netlify[bot] commented 11 months ago

Deploy Preview for ember-deprecations ready!

Name Link
Latest commit 5faee08fa9f9c2a2db74a9ccda9349e261711497
Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/650c9b4024e31c000869dd84
Deploy Preview https://deploy-preview-1339--ember-deprecations.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Baltazore commented 11 months ago

@locks do you want me to split PR into 2 separate (one with 5.0 deprecation, another with 5.3 deprecations) ? Or this one can just wait until EData 5.3 would be released ?

runspired commented 10 months ago

@locks this PR is happening now because @kategengler asked us to PR it and get url's prior to release. Sounds like there's a bit of a mixup somewhere in what's expected, we've never used urls for EmberData deprecations in the past but happy to use them going forward. From what I can tell they are predictable off of the file names in this PR so as long as there are no concerns about the file names I'll update the URLs in-advance in EmberData. Pattern: https://deprecations.emberjs.com/v5.x#toc_<fileName> e.g. https://deprecations.emberjs.com/v5.x#toc_ember-data-deprecate-legacy-imports because file is v5/ember-data-deprecate-legacy-imports.md

kategengler commented 10 months ago

I really don't think there is any harm in showing deprecations for future versions in the deprecation guides. After all, users could be using the beta or canary. Though the guides should be written as if the deprecation is already released.

@runspired For URLs, since https://github.com/ember-learn/deprecation-app/pull/1261 a URL scheme of https://deprecations.emberjs.com/id/<deprecation-id> is available, and, I think, preferable.

@Baltazore Thank you for PRing the deprecation guides.

jaredgalanis commented 10 months ago

merging since we're all released now