Open NullVoxPopuli opened 2 months ago
Name | Link |
---|---|
Latest commit | 3ab460238d391982c481fdd8c6c133b51d5379bc |
Latest deploy log | https://app.netlify.com/sites/ember-deprecations/deploys/669156341cb59e0008e9ae1f |
Deploy Preview | https://deploy-preview-1381--ember-deprecations.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Looks like there is an issue with case sensitivity in the build:
Merge error: conflicting capitalizations:
deprecate-import-Debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api
deprecate-import-debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api
that'll need to get fixed -- as the URLs / ids are generated from the real property names :sweat_smile:
Happens here: https://github.com/emberjs/ember.js/pull/20686/files#diff-aa3f9176575f028f979266539b2a7647d98ec70c72162bd89de74f863c857f8bR95
Looks like there is an issue with case sensitivity in the build:
Merge error: conflicting capitalizations: deprecate-import-Debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api deprecate-import-debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api
that'll need to get fixed -- as the URLs / ids are generated from the real property names 😅
Happens here: https://github.com/emberjs/ember.js/pull/20686/files#diff-aa3f9176575f028f979266539b2a7647d98ec70c72162bd89de74f863c857f8bR95
Hey! Is there anyway we can dasherize and lowercase the importName in your implementation? I think most of the other deprecation ids follow that format.
Hey! Is there anyway we can dasherize and lowercase the importName in your implementation? I think most of the other deprecation ids follow that format.
I suppose, but it introduces risk of not matching 1-1, due to potential for variances in implementation of how dasherize works.
It is done tho
@NullVoxPopuli It looks like this is labeled as since 5.10 but I don't see this in the 5.10 release notes. @kategengler Did we actually get this in? Maybe I'm missing something.
No, it didn't make it to 5.10 (and thus will be until 7.0 at the earliest). It is available but not enabled right now.
RFC: https://github.com/emberjs/rfcs/pull/1003 Implementation: https://github.com/emberjs/ember.js/pull/20686
Advancement: https://github.com/emberjs/rfcs/pull/1015