ember-learn / ember-api-docs

Ember API Docs viewer
https://api.emberjs.com
MIT License
72 stars 116 forks source link

Links on Package @ember-data/store giving 404. #672

Open kyleisuncool opened 4 years ago

kyleisuncool commented 4 years ago

Clicking on push, createRecord, and pushPayload on Package @ember-data/store yields a 404 in 3.16 documentation.

alexeykostevich commented 4 years ago

Possibly related issues:

benmurden commented 4 years ago

I am seeing this here, too. Incognito window doesn't resolve it either, unlike in #704.

Gaurav0 commented 4 years ago

I can still reproduce. Must be a separate issue.

akankshadharkar commented 4 years ago

Any updates on this? I'm facing the same issue today while trying to run the application locally

ijlee2 commented 4 years ago

To provide more information, the links for createRecord, push, and pushPayload do seem to work if we visit the Store class page instead: https://api.emberjs.com/ember-data/release/classes/Store

I haven't looked at the repository code to see how the links for @ember-data/store are created (whether they are hard-coded or automatically generated), but I wondered if the difference between the two pages could give us a starting point for addressing this issue.

jacobq commented 2 years ago

FWIW, this is still broken :'( (See also #704 & #801)

I ran into this again today while browsing API docs for ember-data. I clicked the link for createRecord here. The correct/working destination URL has classes/Store/ in the path.

Looking at the JSDoc comment here it looks like the problem may be that the URL is relative (begins with ../), but this link can be viewed from different URLs, e.g. see list below. I've noticed that simply adding/removing the final trailing / can break it.

Broken:

Working: