search

ember-learn / ember-api-docs

Ember API Docs viewer
https://api.emberjs.com
MIT License
72 stars 116 forks source link

Implement 404 page #906

Closed MehulKChaudhari closed 8 months ago

MehulKChaudhari commented 8 months ago

Fixes: https://github.com/ember-learn/ember-api-docs/issues/884

Desktop:

image

Mobile:

image
netlify[bot] commented 8 months ago

Deploy Preview for ember-api-docs ready!

Name Link
Latest commit 96fbf4dfebab61dbb2e9d40d10b756ac76341a6b
Latest deploy log https://app.netlify.com/sites/ember-api-docs/deploys/65d773aaaaa5e4000855a9a8
Deploy Preview https://deploy-preview-906--ember-api-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MehulKChaudhari commented 8 months ago

Hey @MinThaMie, Please have a look at this PR? I have made changes keeping website-redesign as base branch.

evoactivity commented 8 months ago

Could I suggest something more like this

image image

1) Add padding to the .whoops class, my example screenshots are 4rem on desktop and 2rem on mobile 2) remove flex-direction: column; on desktop 3) reduce size of tomster to around 240px on desktop

MinThaMie commented 8 months ago

I wholeheartedly agree with @evoactivity :) If you implement those changes I'll approve :)

MehulKChaudhari commented 8 months ago

I wholeheartedly agree with @evoactivity :) If you implement those changes I'll approve :)

Made the changes, but Instead of 2rem padding in mobile I have used --spacing-3 variable which is 1.5rem does that work or we should add hard coded 2rem value? @MinThaMie @evoactivity

MinThaMie commented 8 months ago

I'm happy with the --spacing-3

MinThaMie commented 8 months ago

Thank you very much @MehulKChaudhari

MehulKChaudhari commented 8 months ago

Thank you very much @MehulKChaudhari

Thank you, Please let me know if there is any task that I can pick up.