search

ember-learn / ember-cli-addon-docs

Easy, beautiful docs for your OSS Ember addons
https://ember-learn.github.io/ember-cli-addon-docs
MIT License
176 stars 142 forks source link

Path searching for type has incorrect regex #292

Open cah-brian-gantzler opened 5 years ago

cah-brian-gantzler commented 5 years ago

The code at https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/routes/docs/api/item.js#L21 is looking for a type to use when looking for a matching module. However when I have a path that has a directory ending in "s", it fails to find the correct module because the type is incorrect.

Given the path "components/yeti-table/header/filters/column/input" the type on the line above will be "components/yeti-table/header/filter" when it should be "component". If you use the regex /^(.*?)s\// it will find the correct type

Looks like this was introduced with https://github.com/ember-learn/ember-cli-addon-docs/pull/167

It seems pretty straightforward and I would submit a pull request, except looking at the tests I have no idea where I would supply a test for this. It looks like you might have to create an addon that had component ending in "s" with sub components somewhere in your test apps.

cah-brian-gantzler commented 5 years ago

Looking at #167 I see how a test would be done. See if I can get to this

cah-brian-gantzler commented 5 years ago

Guess I need help on how you run test against something in the sandbox

cah-brian-gantzler commented 5 years ago

Anyone able to help me out on how to test this change? How do you run tests against the items created in the sandbox directory?

pzuraq commented 5 years ago

The sandbox is mounted in rhe dummy app, so you can visit URLs there like any other URL in acceptance tests:

await visit(‘/sandbox/TEST_URL’);
cah-brian-gantzler commented 5 years ago

Thanks, think maybe I wrote the test correctly, but now cant seem to run them. When I do "ember t" I get the below error if I run in even on the master branch, so its not something I changed


Build Error (broccoli-persistent-filter:Babel > [Babel: ember-inflector]) in ember-inflector/index.js

You must specify envFlags.flags.DEBUG at minimum.```