search

ember-learn / ember-cli-addon-docs

Easy, beautiful docs for your OSS Ember addons
https://ember-learn.github.io/ember-cli-addon-docs
MIT License
176 stars 143 forks source link

This addon requires ember-decorators? #86

Closed elwayman02 closed 6 years ago

elwayman02 commented 6 years ago

When installing this app but choosing not to use either the yuidoc or esdoc plugins, I still get an error as this addon apparently adds an esdoc-component.js to the consuming app, which cannot be parsed by babel without @ember-decorators:

Build Error (Babel)

dummy/components/esdoc-component.js: Unexpected token (28:2)

  26 |     The count
  27 |   */
> 28 |   @argument
     |   ^
  29 |   @type('number')
  30 |   count = 0;
  31 |

Stack Trace and Error Report: /var/folders/ch/zl0z6ss91tlgt8jkw0kms1wxk3yc3w/T/error.dump.6f467ea407fe206766a0cc449eee3a04.log
pzuraq commented 6 years ago

esdoc-component should only be in an ignored sandbox addon that shouldn’t end up in the npm package, we should verify that npmignore is working correctly

elwayman02 commented 6 years ago

Oooh nvm that's probably what the problem is. I was installing a branch directly from github, so it wasn't using the npm package.