search

ember-learn / ember-help-wanted-webhook

0 stars 5 forks source link

Fixed unlabeling bug #14

Closed acorncom closed 8 years ago

acorncom commented 8 years ago

When a previously labeled issue was unlabeled on a Github repo, the corresponding issue on Firebase would not be marked as closed (but was left open as we didn't enforce closing as part of closing an issue).

/cc @sivakumar-kailasam thoughts?

sivakumar-kailasam commented 8 years ago

When I step back and look at it, I wonder if we should use this app only as a middleware which converts events from github to our desired format on firebase and not worry about labels to consider when processing these events.

The labels will be needed only when we query firebase from the ember app to get the open issues of interest. Does that sound logical 😄 ?

locks commented 8 years ago

@sivakumar-kailasam https://github.com/ember-learn/ember-issue-triage-lambda/blob/master/index.js :trollface:

sivakumar-kailasam commented 8 years ago

@locks huge :trollface:. We have tests with our code 😜 :trollface: