ember-learn / ember-jsonapi-docs

fixes up the ember docs generated by YUIDoc to be in JSONAPI format + some other niceties
9 stars 11 forks source link

some attributes and relationships share a same name #13

Closed MartinMalinda closed 7 years ago

MartinMalinda commented 7 years ago

In this JSON, classes are both an attribute and a relationship. In ember-data, this will result in not being able to have classes: attr() and classes: hasMany() at the same time and maybe other issues.

screen shot 2016-12-14 at 19 12 30

I think this is a blocker for ember-learn/ember-api-docs#122. Classes will have to be sideloaded and private ones filtered out.

toddjordan commented 7 years ago

I think this may have been fixed by #23 @MartinMalinda can you confirm?

MartinMalinda commented 7 years ago

This is fixed. I've totally missed this earlier 😅