search

ember-learn / ember-jsonapi-docs

fixes up the ember docs generated by YUIDoc to be in JSONAPI format + some other niceties
9 stars 11 forks source link

Fixing hardcoded links #24

Closed sivakumar-kailasam closed 5 years ago

sivakumar-kailasam commented 7 years ago

There are links hardcoded in the class descriptions that point to the existing url such as /api/data/classes/DS.ConflictError.html. These need to be corrected to point to the correct versioned url.

sivakumar-kailasam commented 7 years ago

https://github.com/ember-learn/ember-jsonapi-docs/blob/2f180d44c4a6571811fa1972f890146cc4380576/lib/markup.js#L50 we could lookup links here and replace tehm with the path from the api docs ember app.

toddjordan commented 7 years ago

@sivakumar-kailasam how high a priority is this? is it blocking any current functionality?

sivakumar-kailasam commented 7 years ago

@toddjordan Not a blocker since we handle those redirects. Tracked to ensure that its being fixed.

toddjordan commented 5 years ago

Closing since we are handling the case, and are not planning a fix anytime soon. If it becomes an issue again we can still address.