ember-learn / ember-jsonapi-docs

fixes up the ember docs generated by YUIDoc to be in JSONAPI format + some other niceties
9 stars 11 forks source link

Missing API docs #43

Closed jenweber closed 6 years ago

jenweber commented 6 years ago

Please comment with anything else that can't be found

toddjordan commented 6 years ago

htmlSafe: image

toddjordan commented 6 years ago

helper (under package @ember/component) image

toddjordan commented 6 years ago

Ember.Test https://emberjs.com/api/ember/2.16/classes/Ember.Test

toddjordan commented 6 years ago

on() @ember/object/evented image

Turbo87 commented 6 years ago

@jenweber all other methods related to Ember.Object.get() are also missing: set, setProperties, getProperties, toggleProperty, ...

toddjordan commented 6 years ago

@Turbo87 image

toddjordan commented 6 years ago

incrementProperty: https://emberjs.com/api/ember/2.16/classes/Observable/methods/incrementProperty?anchor=incrementProperty

toddjordan commented 6 years ago

Ember.Enumerable is private. If you toggle on private classes its there: https://emberjs.com/api/ember/2.16/classes/Enumerable

Turbo87 commented 6 years ago

@toddjordan what you linked is unrelated. I'm talking about the methods, not the global Ember.get() functions

toddjordan commented 6 years ago

@Turbo87 correct. They are functions of Observable, listed in this item. The @extends annotation of EmberObject needs updating.

http://emberjs.com/api/classes/Ember.Object.html#method_incrementProperty and toggleProperty
update @extends annotation on EmberObject to be {Observable} and not {Ember.Observable}
toddjordan commented 6 years ago

Added fixes to https://github.com/emberjs/ember.js/pull/15716

toddjordan commented 6 years ago

cases identified here are fixed