search

ember-learn / ember-jsonapi-docs

fixes up the ember docs generated by YUIDoc to be in JSONAPI format + some other niceties
9 stars 11 forks source link

Need to account for `reopen` and `@for` #57

Closed Gaurav0 closed 6 years ago

Gaurav0 commented 6 years ago

Looking at https://github.com/emberjs/ember.js/issues/16247 and at the source of https://github.com/emberjs/ember.js/blob/v3.0.0/packages/ember-routing/lib/ext/controller.js

The underlying issue is that ember-jsonapi-docs do not account for the use of reopen and @for in source documentation.

Gaurav0 commented 6 years ago

The fix is likely to be very similar to the one for uses here: https://github.com/ember-learn/ember-jsonapi-docs/blob/d8c217d19f5f68cf03cec9f82e46a9a9722a4e94/lib/add-inherited-items.js#L42-L44

toddjordan commented 6 years ago

@for still works. We just need to change it back from @for ControllerMixin to @for Ember.ControllerMixin

toddjordan commented 6 years ago

Will track in ember-learn/ember-api-docs#468