ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
87 stars 186 forks source link

Use headerLinks directly from ember-styleguide #1047

Closed nickschot closed 1 year ago

nickschot commented 1 year ago

After syncing the menu content in https://github.com/ember-learn/ember-styleguide/pull/473 we can now use the ember-styleguide links object for the menu in ember-website and exclusively manage the header menu items from styleguide preventing them from getting out of sync again.

I've kept the import and pass through replaceLinks since it seems to have some specific behaviour (removing domain prefix, some backward compatible stuff).

netlify[bot] commented 1 year ago

Deploy Preview for ember-website ready!

Name Link
Latest commit e048f5ebd1ac29a29c746136be80423b7f494bfe
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/64c010b2f072e0000898247f
Deploy Preview https://deploy-preview-1047--ember-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

1/14 Files got Smaller 🎉:

Details File | raw | gzip --- | --- | --- ember-website.js|-2.39 kB|-453 B

13/14 Files stayed the same size 🤷‍:

Details File | raw | gzip --- | --- | --- blurhash.js| 0 B| 0 B chunk.143.js| 0 B|+1 B chunk.177.js| 0 B| 0 B chunk.178.js|-2 B| 0 B chunk.208.js| 0 B| 0 B chunk.488.js| 0 B| 0 B ember-website-fastboot.js| 0 B| 0 B polyfill-evergreen.js| 0 B| 0 B polyfill-legacy.js| 0 B| 0 B polyfill-shared.js| 0 B| 0 B vendor.js| 0 B| 0 B ember-website.css| 0 B| 0 B vendor.css| 0 B|-3 B

Created by ember-asset-size-action