ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

Add non supported bugfix and security patch until dates #1083

Closed geneukum closed 7 months ago

geneukum commented 7 months ago

Per this message in the ember-js discord, let's add a couple of new columns (Bugfixes until and Security patches until) to the no longer maintained LTS table on the releases/lts route.

While glossing over this, I think that I caught a few instances where we were showing the incorrect minor version / date for a few LTS versions as well, but definitely worth double checking them.

netlify[bot] commented 7 months ago

Deploy Preview for ember-website ready!

Name Link
Latest commit da562da2f5aadd585932aba32a04882c673e9f77
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/65ca9a26201eb90008905c4a
Deploy Preview https://deploy-preview-1083--ember-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kategengler commented 7 months ago

Thank you for this; if you're up for another PR after this, I think removing that latest minor version column could be useful. It seems like something that is irksome to keep up to date. We could link to the npm versions page instead https://www.npmjs.com/package/ember-source?activeTab=versions

geneukum commented 7 months ago

Thank you for this; if you're up for another PR after this, I think removing that latest minor version column could be useful. It seems like something that is irksome to keep up to date. We could link to the npm versions page instead https://www.npmjs.com/package/ember-source?activeTab=versions

Sure thing! Good idea to switch the last minor date to the promotion date. I think that it was a little funky because some LTS versions received patches after the cutoffs if I remember correctly.

I'll make a separate PR to drop that column and add some text to link to the versions page on NPM instead.

kategengler commented 7 months ago

@ember-learn/learning-core-team who can review Percy?