search

ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

Upgrade to ember-source/cli 5.8, ember-data 4.12, #1109

Closed NullVoxPopuli closed 4 months ago

NullVoxPopuli commented 4 months ago

Builds on top of https://github.com/ember-learn/ember-website/pull/1108

This is just a dep and minimal config change. Some selective addons were also upgraded, ember-styleguide, ember-truth-helpers (to catch up with compatibility of the build tooling)

What should happen next, each in their own PR:

netlify[bot] commented 4 months ago

Deploy Preview for ember-website failed.

Name Link
Latest commit aa1bffa3bbf11f25fa1cda4454a575bc8d111d8f
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/663675835fd5b700082e5d53
NullVoxPopuli commented 4 months ago

Current issue is that loader.js is having a whoopsie image

simonihmig commented 4 months ago

@NullVoxPopuli have you seen https://github.com/ember-learn/ember-website/pull/1076? Didn't you have issues with ED + FastBoot/prember?

NullVoxPopuli commented 4 months ago

I don't have tests running at all, due to something going on with loader.js. Things seem ok in dev / non-test mode though.

Your PR is green, so I'll close this one for now :sweat_smile: