ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

[tutorial] suggested change for unclear phrasing #1113

Open willybeans opened 3 months ago

willybeans commented 3 months ago

The wording in the ember tutorial here where it states "To make this store service available, we must add the following file: export { default } from 'ember-data/store';" is unclear what the next step for the learner is. Is it ok to change the wording here to say something to the effect of "To make this store service available, first we much create a service folder, and in a file service/service.js put the following code". Or like in the other parts of the tutorial, have the banner above the code specifiy the file path, as it current does not display a file path and only shows the string of code:

Screenshot 2024-05-23 at 12 42 32 PM

I apologize if there is a github representation of the tutorial where i could have better referenced the text for this issue. i tried looking in the ember-website codebase and didnt find anything regarding the tutorial content in there, so if this is the wrong place and if someone could point me in the right direction that would be great, and id gladly reopen the issue! Im also a newbie to ember, so sorry if it is, in fact, there!

MinThaMie commented 2 months ago

Hey, thank you for pointing this out. Your solution of adding the file to the top of the code snippet was fixed in the latest guides. We could manually back port that fix. Please let us know if you think that is important!