ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

Adds Polaris mascots #1119

Closed MelSumner closed 2 months ago

MelSumner commented 2 months ago

If merged, this PR adds the Polaris Tomster and Zoey to the website.

CleanShot 2024-07-15 at 16 34 03@2x

netlify[bot] commented 2 months ago

Deploy Preview for ember-website ready!

Name Link
Latest commit dc66290997c21455c07b53d9b8a22f447263a3a1
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/66959ea541e4190009310cc5
Deploy Preview https://deploy-preview-1119--ember-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 months ago

1/14 Files got Bigger 🚨:

Details File | raw | gzip --- | --- | --- ember-website-fastboot.js|+306 B|+58 B

13/14 Files stayed the same size 🤷‍:

Details File | raw | gzip --- | --- | --- blurhash.js| 0 B| 0 B chunk.143.js| 0 B| 0 B chunk.177.js| 0 B| 0 B chunk.178.js| 0 B|-1 B chunk.208.js| 0 B| 0 B chunk.488.js| 0 B| 0 B ember-website.js| 0 B|+1 B polyfill-evergreen.js| 0 B| 0 B polyfill-legacy.js| 0 B| 0 B polyfill-shared.js| 0 B| 0 B vendor.js| 0 B| 0 B ember-website.css| 0 B| 0 B vendor.css| 0 B|-1 B

Created by ember-asset-size-action

MelSumner commented 2 months ago

One of the things I am not sure about is that tests are failing for things I did not change. Is this a known issue?

mansona commented 2 months ago

@MelSumner yes we opted to remove some of the strange mocking implementations of data for the tests because they stopped reflecting reality and we missed a few bugs. Essentially it's a bit more annoying to update the website but it's much safer to make any changes now 👍