search

ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

Page not rendering with node@6.x version #178

Closed abhilashlr closed 5 years ago

abhilashlr commented 5 years ago

While running node@6 and ember serve, the page doesn't load but throws an error under controllers/application.js replaceLinks() method where there is a usage of the spread operator. The same works if ?fastboot=false is used.

Documentation should include running this project from node@8.?

locks commented 5 years ago

This is already specified in the project's package.json. Your node's version may be too old to show the proper warning, can you confirm it doesn't complain?

mansona commented 5 years ago

@abhilashlr I'm afraid @locks is right with this one, it does require a minimum of node v8.x mainly because we rely very heavily on prember which also requires a minimum of node v8.x

I don't know if we should put this in the current readme because as @locks says it does state it in the package.json 🤔 are there any warnings when you try to run it?

I'm going to close this issue but we can continue to discuss if we feel like it 😄

abhilashlr commented 5 years ago

No @mansona @locks , there seems to be no error/warning while running ember serve or npm install command.