ember-learn / ember-website

The emberjs.com website.
https://emberjs.com/
MIT License
86 stars 185 forks source link

[redesign] Add content for the landing page header #314

Closed mansona closed 5 years ago

mansona commented 5 years ago

If this is your first time tackling an issue that is part of the redesign project please read all the Notes section at the bottom of this issue before claiming it and starting to work on it

Screenshot 2019-04-23 at 11 59 04

Add the content for the hero section of the homepage.

Todo

useful documentation


Notes (important)

This issue is part of the Ember Website Redesign RFC and if you are not familiar with the RFC you should read it and look at the example landing page before attempting this issue.

When creating your PR you should target the website-redesign-rfc branch. This way when your PR is merged it will not update master it will instead update the long-lived branch that is tracking the website redesign work.

This issue is strictly to add the content for a section of the homepage. All styles should be provided by the ember-styleguide and we should not be adding styles to the ember-website for any reason.

If you find that there is documentation or implementation lacking in the ember-styleguide to adequately tackle this issue then part of the deliverable of this issue is to document what is missing 👍 this will facilitate improvements in the ember-styleguide that will allow you to complete your work and get your PR merged.

claeusdev commented 5 years ago

@mansona I would like to have a go at this.

mansona commented 5 years ago

hey @claeusdev I have already completed this one in https://github.com/ember-learn/ember-website/pull/362 and I'm just waiting to hear back from Percy to see why CI is breaking on their side.

If you would like to take a look at an issue it would be great if you could check out https://github.com/ember-learn/ember-website/issues/315 👍

claeusdev commented 5 years ago

@mansona Hey lemme check it out and then I'll ping you on discord to get started.