Remove ember-prism config workaround.

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites

https://guidemaker-ember-template.netlify.app/release

MIT License

5 stars 22 forks source link

Remove ember-prism config workaround. #10

Closed rwjblue closed 2 years ago

rwjblue commented 5 years ago

Fixes https://github.com/ember-cli/ember-cli/issues/8448

rwjblue commented 5 years ago

I'm just "rejecting" this in case anyone sees this and thinks it is fixed

Bah, it worked when I did it. I guess I'll attach screenshots next time 😞

rwjblue commented 5 years ago

Did you actually run this before declaring it incorrect?

If you revert the changes made in 43bdcbbb47 (adding the ember-cli-build.js work around) and navigate to /release/examples/syntax-highlighting you see:

Screen Shot 2019-06-17 at 9 52 53 AM

Then when you apply the changes in this PR's second commit (the actual fixing one), you see properly formatted output:

Screen Shot 2019-06-17 at 9 51 32 AM

mansona commented 2 years ago

I'm closing this because we found and fixed the issue in the redesign branch and in https://github.com/empress/ember-showdown-prism