search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

Move new search input to be right aligned #108

Closed mansona closed 1 year ago

mansona commented 2 years ago

In https://github.com/ember-learn/guidemaker-ember-template/pull/107 we have a wonderful new search design 😍 One improvement I would like to make is to actually right-align the search bar

This is similar to what is currently happening in the live guides:

Image

I didn't want to block the previous PR because a) it's awesome and needed to be merged instantly!! and b) this work might need to be done in the ember-styleguide repo 🤔 not 100% sure on that one

MinThaMie commented 2 years ago

Also to fix: overflow of the blue color of the "title"

The tether positioning makes it difficult. We've two options:

  1. Move the tether to tether right and for mobile make it full width results
  2. Move the tether to right for normal screens and left for mobile screens

Image

mansona commented 2 years ago

Tether position is a JavaScript thing right? Or can we do it in CSS? The reason I ask is because I am not a fan of JS based "media queries"

mansona commented 1 year ago

This is done and can be seen on the tracker branch for the guides update: https://deploy-preview-1717--ember-guides.netlify.app/release/ 🎉