ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

clean up the info-banner component #148

Closed mansona closed 1 year ago

mansona commented 1 year ago

This cleans up the implementation of the info-banner component but when testing this I noticed that we didn't have a design for the info banner at all 🙈

We can probably merge this PR before we do any work for #146 or we could just add some design stuff to this PR. What do you think @MinThaMie ?

netlify[bot] commented 1 year ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit d50e84822edf7ed854adddd32a3ddd9bc4460020
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/647e264a0fd6490008eb42d0
Deploy Preview https://deploy-preview-148--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

MinThaMie commented 1 year ago

I would fix it in this PR :) Do we have a design for it or should I just make it nice? Do we know what it looked like before?

What do you think about this one:

Screenshot 2023-06-05 at 10 36 13
github-actions[bot] commented 1 year ago

Some tests with 'continue-on-error: true' have failed: