ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

add prefixHeaderId to on-this-page links #154

Closed mansona closed 1 year ago

mansona commented 1 year ago

In the main ember guides we use showdown config to set a prefix for the header ids so that we didn't break links when we migrated to use Guidemaker for the guides

https://github.com/ember-learn/guides-source/blob/master/config/environment.js#L42-L45

This config needs to be read (if it exists) and set as a prefix to the links in the on-this-page component 👍

netlify[bot] commented 1 year ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit 0638f3369c9c8d285a15070e2d5e081accfca7ce
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/649de8156c0e8d0007173047
Deploy Preview https://deploy-preview-154--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Some tests with 'continue-on-error: true' have failed: