search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

Revert "add prefixHeaderId to on-this-page links" #155

Closed mansona closed 1 year ago

mansona commented 1 year ago

This reverts #154

Essentially it was a nice try to fix the problem but it didn't cover all use cases. The right thing to do was to use the showdown config defined in the environment to build the markdown that we use to find the links on the page with.

This is the fix that we needed: https://github.com/empress/guidemaker/pull/92

netlify[bot] commented 1 year ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit 833f9ff6c01481e0bdcf6c3fba7070ce0e0a2f6b
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/649ef133ef9bef0008471cd3
Deploy Preview https://deploy-preview-155--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Some tests with 'continue-on-error: true' have failed: