search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

Sidebar weirdness (#486) #171

Closed lukasnys closed 8 months ago

lukasnys commented 9 months ago

In https://github.com/ember-learn/ember-styleguide/issues/486, there was mention of some negative margin hack.

This PR upgrades to ember-styleguide@10 removes this negative margin.

Based on https://github.com/ember-learn/guidemaker-ember-template/pull/172

netlify[bot] commented 9 months ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit 718f4091f1a9263d1ee2c07d6c91de37671c27aa
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65e1f97d250b8d0008f0e2b5
Deploy Preview https://deploy-preview-171--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lukasnys commented 9 months ago

This change makes the sidebar quite a bit narrower. Can we make it so the original width stays the same?

In a way this is now more aligned with the ember-styleguide but it does make sense to have it stay the same width.

I'll see if I can create a PR to ember-styleguide to increase the sidebar-width variable as imo it's a bit too narrow now.