search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

cleanup: remove redundant toc styles #172

Closed lukasnys closed 8 months ago

lukasnys commented 9 months ago

I noticed the table-of-contents styles were added into ember-styleguide (https://github.com/ember-learn/ember-styleguide/commit/add121dbf6aec2c5e61eaaa65bae0f2e69da2284) but they were also still in guidemaker-ember-template.

As described in the 9.0.0 release notes, support for Ember<3.28 and Node<18.0 was dropped, but in Guidemaker we're on ember-source@3.28 and node@18 so this shouldn't impact us.

netlify[bot] commented 9 months ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit fbd15dbbd5878014d67951c9ae30cad545466add
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65e1f8f331d3000008726dfb
Deploy Preview https://deploy-preview-172--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IgnaceMaes commented 9 months ago

The shikiji styleguide dependency has been removed in https://github.com/ember-learn/guidemaker-ember-template/pull/170, so that part can be dropped here.

lukasnys commented 9 months ago

The shikiji styleguide dependency has been removed in #170, so that part can be dropped here.

Done!

IgnaceMaes commented 9 months ago

LGTM, but a second quick review would be nice as I'm not 100% up to speed with the style guide changes.

mansona commented 8 months ago

the whole file was deleted in #171 so we can close this 👍