search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

Convert to a V2 addon and drop support for Ember < 3.28 #188

Closed mansona closed 5 months ago

mansona commented 6 months ago

Roughly speaking I ran ember init -b @embroider/addon-blueprint --pnpm to get this far, and then did some tweaking

Sure this is a little extreme but it's at least possible so we should consider it (maybe) 😂

netlify[bot] commented 6 months ago

Deploy Preview for guidemaker-ember-template ready!

Name Link
Latest commit 48a1c076602ac19d844cf1f82e3a523555cfcd27
Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/6633ffbe0105f60008737b65
Deploy Preview https://deploy-preview-188--guidemaker-ember-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IgnaceMaes commented 5 months ago

The callout images are not present, that seems unexpected?

https://deploy-preview-188--guidemaker-ember-template.netlify.app/release/examples/callouts

image
IgnaceMaes commented 5 months ago

Images look all good now with the latest Embroider version!

Only thing missing seems to be the icons:

image