Add CSS styling for tables

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites

MIT License

5 stars 22 forks source link

Closed IgnaceMaes closed 4 months ago

IgnaceMaes commented 4 months ago

Currently tables are unstyled in the guides. Some CSS should be written for the table element so it looks nicer.

Ziphozenkosimthombe commented 4 months ago

can I take that?

IgnaceMaes commented 4 months ago

Feel free to give it a go!

Some extra details:

The styleguide should be used for color and spacing variables: https://ember-styleguide.netlify.app/concepts/colors/
An example of a table should be added to a markdown file in the test app so this can be revieed.
There is no design ready to follow. I think it would be nice to make the table full width. Try to make it fit in with the rest of the page.

Ziphozenkosimthombe commented 4 months ago

if I ask the table I should add it to the test-app folder inside the readme file? can you please give me more guidance on that.

ArunPragadeeswar007 commented 4 months ago

@IgnaceMaes please review this PR