search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

Design an approach for the search dropdown in the Guides #41

Closed mansona closed 2 years ago

mansona commented 4 years ago

Here is the current implementation: Screenshot 2020-03-30 18 18 30

Note: the new design must have "Search by Algolia" as we have a sponsored account

Note we need a design for all aspects of the search dropdown (empty state, loading state etc)

If anyone wants to work with the HTML on this I have opened a branch on guidemaker-ember-template called algolia-tests that we can use the "pauseTest() method" to easily get back to the same place.

https://github.com/ember-learn/guidemaker-ember-template/blob/algolia-tests/tests/acceptance/search-test.js#L15-L16

For reference the "pauseTest() method" is to run the test locally and put it in Development mode so you can change files and you get back to having the dropdown open again without having to click 👍

MinThaMie commented 2 years ago

The design is done and the code committed to the branch :)

Screenshot 2022-08-05 at 14 51 44 Screenshot 2022-08-05 at 14 51 51
mansona commented 2 years ago

merged in https://github.com/ember-learn/guidemaker-ember-template/pull/107