ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

Cleanup deprecations in guidemaker-ember-template #65

Closed jenweber closed 2 months ago

jenweber commented 3 years ago

Description

This work should be done on the branch website-redesign. We updated the Ember version, and so we can see new deprecations. The goal of this ticket is to resolve the deprecations. This may be done in several PRs.

To-do:

Supporting information

You can see the progress so far at https://github.com/ember-learn/guidemaker-ember-template/pull/61

sumitd94 commented 3 years ago

I will start checking the deprecation and start working on it. I Will comment here on what I am fixing 👍

mansona commented 3 years ago

hey @sumitd94 👋 sorry I didn't see you message before now, are you still hoping to work on this? Do you need any help?

sumitd94 commented 3 years ago

hey @sumitd94 👋 sorry I didn't see your message before now, are you still hoping to work on this? Do you need any help?

yes, I am still on it. I will reach out to you incase I need any help :) Thanks!

mansona commented 2 years ago

A lot of the deprecations are actually coming from Guidemaker itself right now.

We're currently blocked on fixing this (and getting CI green again) with https://github.com/empress/guidemaker-default-template/pull/21 which is waiting on a release of ember-power-select.

Once that is merged (and released) we can release a version of guidemaker that has a fully green CI (with no deprecations) and then we can finally fix the deprecations in guidemaker-ember-template 🎉

MinThaMie commented 2 months ago

We are quite up to date right now, so I'm closing this issue