search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

add ember-scroll to guidemaker and remove link-to override #70

Closed mansona closed 3 years ago

mansona commented 3 years ago

This is something that we learned from our work on empress-blog, the scroll behaviour should be in the core addon and not need to be implemented in each of the templates.

Take a look at https://github.com/empress/empress-blog/pull/97 for inspiration of what needs to be done.

the link-to override needs to be removed from guidemaker-ember-template and guidemaker-default-template and ember-scroll needs to be added to guidemaker

mansona commented 3 years ago

We discussed this in the last few Ember Website Redesign meetings and @nickschot is going to apply ember-scroll to the ember-website as a test to fix some issues that he has identified in Safari. After that's done Nick will then add it to guidemaker 👍