ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

use the progress bar in the guidemaker template #74

Closed mansona closed 3 years ago

mansona commented 3 years ago

Use the newly added ProgressBar Component to the guidemaker-ember-template

rember to target the website-redesign branch

sumitd94 commented 3 years ago

Hey, can I take this up and raise the PR? I have the changes ready 😅 It's just a one-liner.

jaredgalanis commented 3 years ago

@sumitd94, please feel free to pick this one up. Thanks for being willing to help! 😄

sumitd94 commented 3 years ago

@sumitd94, please feel free to pick this one up. Thanks for being willing to help! 😄

Thanks for assigning me this issue. can you please also give me permission to push changes to this branch. I am getting an error Permission to ember-learn/guidemaker-ember-template.git denied to sumitd94.

jaredgalanis commented 3 years ago

No probs! You should probably fork the repo and create your own branch. Does that make sense?

On Sun, Jun 6, 2021 at 12:08 PM Sumit Dhanania @.***> wrote:

@sumitd94 https://github.com/sumitd94, please feel free to pick this one up. Thanks for being willing to help! 😄

Thanks for assigning me this issue. can you please also give me permission to push changes to this branch. I am getting an error Permission to ember-learn/guidemaker-ember-template.git denied to sumitd94.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/ember-learn/guidemaker-ember-template/issues/74#issuecomment-855422412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQDRD3MIWD6VXGMMISIGLDTROMRTANCNFSM427TSL7A .

sumitd94 commented 3 years ago

No probs! You should probably fork the repo and create your own branch. Does that make sense? … On Sun, Jun 6, 2021 at 12:08 PM Sumit Dhanania @.***> wrote: @sumitd94 https://github.com/sumitd94, please feel free to pick this one up. Thanks for being willing to help! 😄 Thanks for assigning me this issue. can you please also give me permission to push changes to this branch. I am getting an error Permission to ember-learn/guidemaker-ember-template.git denied to sumitd94. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQDRD3MIWD6VXGMMISIGLDTROMRTANCNFSM427TSL7A .

ah! you are right. I will do that. Thanks :)

mansona commented 3 years ago

I don't know why this didn't automatically close 🙃