search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

move the pagination from the blog design to the styleguide #75

Closed mansona closed 1 year ago

mansona commented 3 years ago

https://github.com/ember-learn/empress-blog-ember-template/blob/master/addon/components/pagination.hbs

make it so that it can work for the blog and the guides at the same time

consider "borrowing" the animation implementation from https://guides.emberjs.com/release/getting-started/

prakashchoudhary07 commented 3 years ago

I'd like to take this up. Will send out a PR by next week.

mansona commented 3 years ago

@prakashchoudhary07 thanks for taking this one! I've moved the task into "in progress" because you're looking at it. Let me know if you have any questions 👍

mansona commented 3 years ago

Hey @prakashchoudhary07 how are you getting on with this issue? do you need any help with it?

prakashchoudhary07 commented 3 years ago

Hey, @mansona I have raised a WIP PR, please have a look here. Sorry for the delay.

prakashchoudhary07 commented 3 years ago

@mansona Please review the WIP PR :smiley: