ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 22 forks source link

Support configuring default branch name #76

Closed ijlee2 closed 3 years ago

ijlee2 commented 3 years ago

Description

The project assumed that the default branch name of a GitHub repo is master:

https://github.com/ember-learn/guidemaker-ember-template/blob/0245119e8ce524b568cb259f13308d03135157b7/app/templates/components/guides-article.hbs#L11

When we update the default branch name to main, clicking on the edit link in the consuming app will lead to a 404 page on GitHub. (GitHub currently supports redirecting view links only, and not edit links.)

Related issue: https://github.com/ember-learn/cli-guides/issues/228

Possible solutions