search

ember-learn / guidemaker-ember-template

Guidemaker template for Ember Guides websites
https://guidemaker-ember-template.netlify.app/release
MIT License
5 stars 21 forks source link

BREAKING: Fix CI for ember-release and update minimum Ember version #78

Closed mansona closed 3 years ago

mansona commented 3 years ago

This also optimises the GitHub actions CI file to one that @Turbo87 recommended 👍

jenweber commented 3 years ago

Hi @ijlee2 for some context, we are digging out of CI not passing at all and not being able to run a release. This is a stopgap, minimal change PR to support the new configurable default branch, so there are some liberties here like with removing LTS checks greater than the library version. The main development is happening on another branch with the website redesign work.

jenweber commented 3 years ago

@mansona I can try to take a look at that last failing test later today

ijlee2 commented 3 years ago

@jenweber I see, thanks for providing more context.

For ember-lts-3.4, the error message showed Element modifiers are not allowed in components (caused by ember-basic-dropdown/templates/components/basic-dropdown-content.hbs?).

I wonder if the error is related to https://github.com/ember-template-lint/ember-template-lint/issues/696, where the proposed solution was to update ember-template-lint. Maybe try installing this addon instead of ember-cli-template-lint?

I'm not sure what's going on with ember-canary yet.

mansona commented 3 years ago

@ijlee2 regarding the template lint stuff, it's not a linting issue it's actually a template compiler error caused by incompatibilities in more recent Ember versions and the addons that we depend on. I have solved the issues with ember-power-select and as I suspected we're probably now stuck on ember-bootstrap 🙈

jenweber commented 3 years ago

@mansona what do you recommend as next steps?