search

ember-learn / guides-source

This repository contains the Ember.js Guides
https://guides.emberjs.com/
MIT License
158 stars 498 forks source link

Hide navbar search icon from Percy #1372

Closed amyrlam closed 4 years ago

amyrlam commented 4 years ago

Percy shows the es-navbar magnifying glass as a change in every build:

image

from https://percy.io/Ember/guides-app/builds/4695682?utm_campaign=Ember&utm_content=guides-app&utm_source=github_status_public

I'm not sure where to make this edit in the guides-source repo?

image

Confused why I don't see es-navbar or EsNavbar or navbar in a "source of truth" spot in the repo or even Search the guides text?

I know how to hide certain CSS in Percy: https://docs.percy.io/docs/percy-specific-css#section-hiding-regions-with-percy-specific-css

Let me know if you have any ideas!

amyrlam commented 4 years ago

Adding a note for posterity cc @jenweber:

This is a known issue on Percy's side and there is nothing that we can do on our end. There is an Intercom thread on this subject where @mansona was working with them

amyrlam commented 4 years ago

https://github.com/ember-learn/guidemaker-ember-template/blob/master/app/templates/application.hbs here is the navbar input

i can see if Percy-specific CSS carries over from one repo to another

amyrlam commented 4 years ago

This seems fixed now! https://github.com/ember-learn/guides-source/pull/1396