deps: install latest `guidemaker-ember-template` to switch to shiki

ember-learn / guides-source

This repository contains the Ember.js Guides

https://guides.emberjs.com/

MIT License

159 stars 487 forks source link

Closed IgnaceMaes closed 1 week ago

IgnaceMaes commented 5 months ago

Upgrades to the latest guidemaker and guidemaker-ember-template version
- This includes sidebar improvements, switching to Shiki for gjs/gts syntax highlighting, ...
Also changed the code block langs to gjs where used, to test this.

netlify[bot] commented 5 months ago

Name	Link
Latest commit	e69dd5d477deed6ead45a05d06baab02125d2b61
Latest deploy log	https://app.netlify.com/sites/ember-guides/deploys/667bbbe563663600083c7f89
Deploy Preview	https://deploy-preview-1997--ember-guides.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IgnaceMaes commented 2 weeks ago

The breaking change since converting guidemaker and dependencies to a v2 addon is the Ember Data integration.

When switching a version via the dropdown it logs:

TypeError: Cannot read properties of undefined (reading 'queryRecord')

In guidemaker/controllers/version.

@mansona IIRC there were some Ember Data reexport magic in the v1 addon that were changed. Do you have an idea how to proceed here?

IgnaceMaes commented 1 week ago

Upgrading to the latest guidemaker patch fixed this 🎉

Should be ready to go now!