ember-learn / guides-source

This repository contains the Ember.js Guides
https://guides.emberjs.com/
MIT License
159 stars 487 forks source link

Diff in example is not working #2035

Closed rgaiacs closed 2 weeks ago

rgaiacs commented 2 weeks ago

In https://guides.emberjs.com/release/components/template-lifecycle-dom-and-modifiers/, we have

Screenshot 2024-06-18 at 15-18-08 Template Lifecycle DO

The code source is

First, we add actions to handle the `click` events for the `Play` and `Pause` buttons:

```handlebars {data-filename="app/components/audio-player.hbs" data-diff="-3,+4,-5,+6"}
<audio src={{@srcURL}} />

<button type="button">Play</button>
<button type="button" {{on "click" this.play}}>Play</button>
<button type="button">Pause</button>
<button type="button" {{on "click" this.pause}}>Pause</button>


The `data-diff` is not working.
IgnaceMaes commented 2 weeks ago

Looks okay on my end.

image

Is that a screenshot from the live version, or a local one? The filename is off in yours too, as it contains quotes.

If it's the live version, can you provide more details like browser version and OS to reproduce this on?

rgaiacs commented 2 weeks ago

Dear @IgnaceMaes, Thanks for the reply.

Is that a screenshot from the live version, or a local one?

Live version with Firefox. Unfortunately, I cannot reproduce now.

Firefox

Version 127.0 (64-bit)

OS: Windows 10 Enterprise

OS Version: 22H2

OS Build: 19045.4529

Now, It looks good as in the screenshot on https://github.com/ember-learn/guides-source/issues/2035#issuecomment-2176695666.

Google Chrome

Version 125.0.6422.176 (Official Build) (64-bit)

OS: Windows 10 Enterprise

OS Version: 22H2

OS Build: 19045.4529

It looks good as in the screenshot on https://github.com/ember-learn/guides-source/issues/2035#issuecomment-2176695666.