jenweber commented 5 years ago

Ember Data has restructured their repo so that it has packages, similar to how in Ember we do import { inject as service} from '@ember/service' instead of import Ember from 'ember'. This feature will probably land in 3.10 or 3.11, so we should get ready for these changes.

A PR should branch from master and target master, and will be merged once that version of Ember Data is released.

To-do:

[x] Find times when import DS from 'ember-data' is used in the guides, and fix them to reflect the new package structure. You can figure out the new imports by looking at the master branch of ember-data. Guides-source have ~60 results.
[ ] look for links to the API Docs for Ember Data, like https://api.emberjs.com/ember-data/release/modules/ember-data. Update them as best you can. Note that the links checkers tests will fail until that version of Ember Data is released and available in the API docs. So just ignore those link check tests while you are working, but keep an eye out for other test failures

Part of https://github.com/emberjs/rfc-tracking/issues/11

maxwondercorn commented 5 years ago

It doesn't look like anyone picked this one up. I'll work on this

jenweber commented 5 years ago

Thank you, that would be awesome!!!

maxwondercorn commented 5 years ago

@jenweber Looks like @bmac has already started working on this in pr #814

jenweber commented 5 years ago

814 will take care of the imports. Links will be harder to figure out. I messaged the data team to see if they have tried to build the API docs yet using the new packages layout.

locks commented 2 years ago

@jenweber did this happen, and if not, should it?

ember-learn / guides-source

Work for 3.10 or 3.11 - update code blocks to reflect new import paths for ember-data packages #740

814 will take care of the imports. Links will be harder to figure out. I messaged the data team to see if they have tried to build the API docs yet using the new packages layout.