search

ember-learn / whats-new-in-emberland

Overview page of current week's updates and changes from Ember core and community repos.
2 stars 14 forks source link

Allow main container to reach full height #59

Closed ijlee2 closed 4 years ago

ijlee2 commented 4 years ago

Problem

When there isn't enough content on a page (this can happen in both index and pull-requests routes), the user sees a "chopped" screen because the main container didn't get full height (100% of the available screen height).

TODOs

References

aditimaurya commented 4 years ago

Hey, I would like to resolve this issue. if you haven't assigned this to anyone then can I work on this?

ijlee2 commented 4 years ago

Hi, @aditimaurya. Thanks for taking an interest in helping out with this issue! Yep, I can assign the issue to you to work on.

I created the issue for Hacktoberfest, which will begin in 10 days. If you wanted to participate in the event, would you like to wait on working on a solution until October 1st?

In the meantime, I'd suggest trying out:

Trying out these steps would help us discover early issues a new contributor might face during Hacktoberfest. ✨

aditimaurya commented 4 years ago

@ijlee2 I'm planning to take part in hacktoberfest, thanks a lot for assigning this to me. In the mean time, before the fest start I'll read the guidelines once again and try to dig deeper into this project so that I can contribute mre efficiently.

ijlee2 commented 4 years ago

Awesome, thanks again!

aditimaurya commented 4 years ago

@ijlee2 Can you please help me with installations, because I'm not able to run the code an see the website and hence not able to propose any changes, I've read the read me, tried to install the same but things are getting very complicated. Can you please guide me? Being very honest, I'm a beginner so maybe that's why facing issues. I hope you'll help me with that.

ijlee2 commented 4 years ago

@aditimaurya Yep, I'm happy to help! Let me reply with another message for more detailed installation instructions.

To confirm, were you able to run an Ember app before (e.g. for work or hobby project) but you were having trouble with running this particular app? I was wondering if you installed Node.js (v12 or v14 recommended), npm, and Ember CLI already. I think you can check by running the command,

# Type in a terminal
ember --version

# Output may look something like:
ember-cli: 3.21.2
node: 12.16.1
os: darwin x64

For more information on installing these 3, you can visit:

https://guides.emberjs.com/release/getting-started/quick-start/#toc_install-ember

ijlee2 commented 4 years ago

Hey, I've installed all of them, and also generated a token, but I'm facing problems when it comes to run "yarn". My IDE or cmd prompt is not taking the command "install yarn" or "yarn install". And so I'm not able to proceed further. I haven't used emberland before, I'm just trying to learn new things and exploring open-source community to work. I hope this information might help you to get what issues I'm facing.

@aditimaurya Yep, that information was perfect! I appreciate your explaining the steps that you've tried. It helps a maintainer understand whether their assumptions about a project were correct.

In general, you will find that Ember apps and addons rely on either npm or yarn to manage the packages (libraries) that they installed. You can guess which package manager to use in 2 ways:

whats-new-in-emberland uses yarn, so let's first check that you have yarn installed on your computer. I think, if you do have yarn, then you will see a version number when you run the following command in your terminal:

# Try running:
yarn --version

# Output may look something like:
1.22.5

If you get an error message instead, I think it's possible that you currently don't have yarn installed and need to. For more information on installing yarn, I recommend following the steps described in https://classic.yarnpkg.com/en/docs/install . The website will tell you what you need to do for a given OS (operating system).

Can you try installing yarn and let me know how it went?

ijlee2 commented 4 years ago

I've updated the installation instructions in README. Hope they are a little more clear.

Just in case, will you check that you forked the repo and create the pull request from your forked repo? If you have any questions, feel free to ask. Thanks!

https://github.com/ember-learn/whats-new-in-emberland#installation

ijlee2 commented 4 years ago

Hi, @aditimaurya. I want to check in to see if you were able to get the repo locally installed and running. Please feel free to let us know if you need additional help.

This Saturday (Oct 10) at 9 am and 9 pm EST, you can join a live mentoring event. Please check the #hacktoberfest channel on Ember Discord for more information!

aditimaurya commented 4 years ago

Hi @ijlee2 , sorry I got busy with my exams so not able to make time. I'll try to follow up the guidelines again tomorrow and will let you know if I'll face any difficulty. I'll surely join the event on Saturday 🎉 Thanks a lot for your invitation!!!! ( I've joined the discord , thanks again)

ijlee2 commented 4 years ago

Thanks for a quick reply, I hope your exams went well! Please feel free to give priority to your studies.

Cheers,