ember-nexus / api

Knowledge Graph API
https://ember-nexus.github.io/api
GNU Affero General Public License v3.0
11 stars 3 forks source link

Replace flysystem's AWS integration with `async-aws/s3` #235

Closed Syndesi closed 8 months ago

Syndesi commented 8 months ago

While league/flysystem is a great library for interacting with files, it does not support all required features like multi part uploads/downloads.

Using aws/aws-sdk-php was considered, but due to the bundle size - 41 MB just for S3 support - it will not be used.

async-aws/s3 on the other hand supports multi part uploads, multi part downloads and is quite a bit smaller (962 KB).

Syndesi commented 8 months ago

league/flysystem itself is not removed, just AWS integration. The remaining parts of flysystem is still used elsewhere, e.g. backup generation.