search

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

`<Foo bar={{baz}}/>` fails #10

Closed Turbo87 closed 6 years ago

Turbo87 commented 6 years ago 
<OpenHomeMobile @platform="ios" @goToMobileSite={{action goToMobileSite}}/>

resulted in Unclosed element 'openHomeMobile' (on line 4).

Adding a space before the /> solved the issue.

rwjblue commented 6 years ago

@Turbo87 - What Ember version? Does the same happen for <div data-blah={{action lol}}/>?

rwjblue commented 6 years ago

Yeah, looks like an issue with glimmer-vm. Transitioning from the mustache state to tag end state seems to require a space...

Turbo87 commented 6 years ago

This was with ember-source@3.0.0

rwjblue commented 6 years ago

Ya, but I think it would have the same issue back to 2.10 all the way through current glimmer-vm master. We'll have to fix it over there I think since the error happens before our AST transform has a chance to run...

Turbo87 commented 6 years ago

yep, that's what I feared. would probably still be good to document it in a "Caveats" section.

rwjblue commented 6 years ago

I created https://github.com/glimmerjs/glimmer-vm/issues/829 to track actually fixing.