search

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

Container memory leak #28

Closed bobisjan closed 6 years ago

bobisjan commented 6 years ago

Hi,

based on the @ryanto's video https://embermap.com/topics/memory-leaks/do-i-have-a-memory-leak (thanks), I've found that this add-on is leaking container in tests in our application.

I've created this branch https://github.com/bobisjan/ember-memory-leaks/tree/ember-angle-bracket-invocation-polyfill, which reproduces the issue.

new app without add-on

screen shot 2018-07-17 at 13 33 56

new app with add-on

screen shot 2018-07-17 at 13 37 58

I'll try to deep dive into this, but I'm not familiar with these internals 🙈.

Thanks for this add-on 🤩.

bobisjan commented 6 years ago

It looks that the problem is with assignment of _splattributes onto global BUILTIN_MODIFIERS.