ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

Fix class merging and attribute precedence #56

Closed ef4 closed 5 years ago

ef4 commented 5 years ago

This fixes #25.

In addition to special-casing the "class" attribute, this also fixes attribute precedence when an attribute is placed before vs after ...attributes.

I eliminated the use of references whose value contains more references. I found it hard to reason about when composing across arbitrarily many levels. Now all the references represent true usermode values, and we use PathReference get for peeling individual references off of hashes.

Edit to add: forgot to mention, but now this polyfill is "more correct" than Ember until https://github.com/emberjs/ember.js/pull/17533 is fixed.