search

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

should this use the Addon.prototype.isEnabled flag instead? #58

Open stefanpenner opened 5 years ago

stefanpenner commented 5 years ago

Should this use the Addon.prototype.isEnabled flag instead?

At first glance, it appears this add-on simply wants itself to be skipped if not needed, this may be a simpler approach.

rwjblue commented 5 years ago

Simpler than?

stefanpenner commented 5 years ago

guarding functionality with https://github.com/rwjblue/ember-angle-bracket-invocation-polyfill/blob/master/index.js#L60 shouldPolyfill

rwjblue commented 5 years ago

Sure, I see. Ya, definitely could change it but it honestly doesn’t seem simpler to me...