Can't set `class=` attribute

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License

76 stars 33 forks source link

Can't set `class=` attribute #62

Open amk221 opened 5 years ago

amk221 commented 5 years ago

I'm not sure what combination of dependencies causes this, but a simple example of:

<MyComponent class="foo" />

is not rendering the class attribute.... changing to @class fixes it, but that's wrong?

Demo repo with failing test:

https://github.com/amk221/-ember-angle-brackets-in-addon/blob/master/tests/integration/components/my-component-test.js#L13

rwjblue commented 5 years ago

Looks like you are hitting the issue reported in https://github.com/emberjs/ember.js/pull/17533. This should have been fixed in ember-source@3.9.1 (by https://github.com/emberjs/ember.js/pull/17870), but it looks like you are already using 3.9.1 and therefore shouldn't have this issue... 🤔

@chancancode - Anything obvious I missed?

rwjblue commented 5 years ago

@amk221 - I've kicked off https://github.com/rwjblue/ember-angle-bracket-invocation-polyfill/pull/63 to see if the test we added shows an issue under 3.9...

amk221 commented 5 years ago

👋🏻Any update on this?

amk221 commented 5 years ago

Hi again, any idea what I can do to help with this?

rwjblue commented 5 years ago

Maybe send in a failing test showing input / output expectations? I was fairly sure that this was fixed...

amk221 commented 5 years ago

I did do a failing test in the example repo, but I will try to add one directly to ember-angle-bracket-invocation-polyfill

amk221 commented 5 years ago

I've done a bit of digging...

If I install ember-font-awesome into my failing test demo repo, then it passes.
Similarly, if I add my failing test from the demo repo to ember-angle-bracket-invocation-polyfill, and uninstall ember-font-awesome, then that test fails with ember try:one ember-lts-3.8

I realise this is a bit odd and maybe not helpful.

I hope it’s not something stupid. I’d hate it to be a red herring.

rwjblue commented 5 years ago

Yikes. That is indeed odd.

amk221 commented 5 years ago

Here is a build of ember-angle-bracket-invocation-polyfill without ember-font-awesome

Most builds pass, apart from ember-3.4 and ember-3.8

amk221 commented 4 years ago

👋 Being able to set class= as an attribute is a very common requirement...

I'm starting to get a backlog of test failures on travis where this polyfill isn't working. Making it impossible to release new versions of my addons with backwards compatibility.

I'm surprised nobody else is experiencing this

rwjblue commented 4 years ago

I'm sorry, I haven't had enough time lately to be able to dig into your demo. I will try to put this back on my queue to dig into, but I'm not sure what that means timeline wise...

amk221 commented 4 years ago

That's ok.

In the meantime, I will try to factor out font-awesome from ember-angle-bracket-invocation-polyfill's test suite

Panman82 commented 4 years ago

FWIW, I think I'm running into this too. It seems passing class="" into a splattributes isn't working below 3.9. Any chance this polyfill can account for the issue? Or is that something that would need to be backported in ember (which is not likely to happen)? https://travis-ci.org/froala/ember-froala-editor/builds/624378772