search

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

WIP: Fix attributes not available in didRender #65

Open simonihmig opened 5 years ago

simonihmig commented 5 years ago

See #64

simonihmig commented 5 years ago

@rwjblue did a quick naive PoC changing the order in commit() as you suggested in Discord: image

And indeed that commit makes the previously failing test pass for Ember 2.16 and 2.18!

Ember 3.1 - 3.3 are still failing, as they use a different if-block of the runtime polyfill, and I was not sure how to approach them (also patching the Glimmer environment as in the older versions?). Also the patched commit does not work at all for Ember 2.12.

But at least this seems to confirm your thoughts that the issue is related to the order how modifiers and component hooks are called. I feel I am not really able to efficiently dig further into this, as I am missing too much context about the internals involved here. But hopefully this makes it easier to pick this up? Would you be able to do so? 🙏