search

ember-polyfills / ember-angle-bracket-invocation-polyfill

MIT License
76 stars 33 forks source link

Fix <LinkTo> usage with `class` attribute. #82

Closed Alonski closed 5 years ago

Alonski commented 5 years ago

Using a helper in a class property doesn't render the class in the rendered HTML.

Example: 

<LinkTo @route="foo" class={{concat "main"}}>Link</LinkTo>

Expected HTML:

<a href="/foo" class="main ember-view">Link</a>

Actual:

<a href="/foo" class="ember-view">Link</a>

Fixes: #83

simonihmig commented 5 years ago

@Alonski It seems you are running into the same linter issue as me a few times: CI runs with the latest dependencies, where prettier rules are slightly different, so what's passing locally is failing in CI. You would have to yarn --no-lockfile and yarn lint:js --fix locally to fix the linting error that is failing the build in CI!

I just created #84 to fix this...

Alonski commented 5 years ago

@simonihmig Ready 4 Review :) Thanks!