ember-polyfills / ember-cached-decorator-polyfill

Polyfill for RFC 566: @cached
MIT License
20 stars 6 forks source link

feat: patch `ember-cli-babel` #12

Closed buschtoens closed 4 years ago

buschtoens commented 4 years ago

Closes #1. Closes #2.

This removes the not reliably working patch-package hackery and replaces it with different h4xx.

We now patch the consuming parent's instance of ember-cli-babel to rewrite the { cached } from '@glimmer/tracking' import to Ember._cached, just before applying the other rewrites from babel-plugin-ember-modules-api-polyfill.

I think this is a quite mean hack, but given that we can remove it, as soon as the RFC gets accepted & https://github.com/ember-cli/ember-rfc176-data/pull/322 gets merged, I think it's acceptable as an intermittent solution.

I'd still like add a more sophisticated test harness with a monorepo setup, so test that this works reliably in apps, addons, engines and Embroider.