search

ember-polyfills / ember-cached-decorator-polyfill

Polyfill for RFC 566: @cached
MIT License
20 stars 6 forks source link

Simplify TS setup to avoid needing custom `paths` #144

Closed dfreeman closed 2 years ago

dfreeman commented 2 years ago

Having consumers update their tsconfig's paths setup to reference a specific dist path under node_modules is a bit fragile, and also not a typical setup burden for adding a new package.

Since we can accomplish the same thing using declaration merging and avoid making any assumptions about @glimmer/tracking's dist layout, this PR proposes doing exactly that.

Note that this is a breaking change for anyone who followed the previous setup instructions. They'll need to remove the paths entry for @glimmer/tracking from their tsconfig for the types to resolve correctly.

/cc @chriskrycho

chriskrycho commented 2 years ago

I merged this but am not sure I have publish permissions. @rwjblue – can you release with this?