search

ember-redux / ember-redux-observable-shim

Ember shim for redux-observable
MIT License
4 stars 1 forks source link

Doesn't work with latest redux-observable v0.17.0 version #3

Open SlyDen opened 6 years ago

SlyDen commented 6 years ago

It looks like redux-observable module has index.js in different folder now lib/esm instead of lib/es. So it breaks here 

const observablePath = path.dirname(require.resolve('redux-observable/lib/es/index.js'));
toranb commented 6 years ago

https://github.com/redux-observable/redux-observable/pull/329

I've pinned the version of this shim to ~0.16 and released a v1.1.1 to solve that issue

Next I tried to bump this to v2.0 and add support for ~0.17 but I'm getting a fun error ;)

screen shot 2017-11-08 at 7 45 00 pm

^^ Anyone else see this if they hack the addon to boot ~0.17 ? I noticed it's very new so I may swing back to this in a week for good measure

toranb commented 6 years ago

screen shot 2017-11-08 at 7 47 51 pm

SlyDen commented 6 years ago

I cloned the shim's repo updated to 0.17.0 and tried to run the tests and got the same issue ... that's why instead of PR I made this ticket :) ... I thought I wasn't that familiar with redux-observable yet to find the problem just from the start and maybe you'll get the idea ... I'm going to dig deeper the issue these days